Re: [PATCH 3/3] usb: type-c: UCSI ACPI driver
From: Heikki Krogerus
Date: Wed Feb 10 2016 - 05:24:01 EST
On Tue, Feb 09, 2016 at 10:22:46AM -0800, Greg KH wrote:
> On Tue, Feb 09, 2016 at 07:01:23PM +0200, Heikki Krogerus wrote:
> > Driver for ACPI enumerated UCSI devices.
>
> What does this mean?
>
> What does the driver do? Why would we care?
>
> >
> > Signed-off-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>
> > ---
> > drivers/usb/type-c/Kconfig | 10 ++++
> > drivers/usb/type-c/Makefile | 1 +
> > drivers/usb/type-c/ucsi_acpi.c | 133 +++++++++++++++++++++++++++++++++++++++++
> > 3 files changed, 144 insertions(+)
> > create mode 100644 drivers/usb/type-c/ucsi_acpi.c
> >
> > diff --git a/drivers/usb/type-c/Kconfig b/drivers/usb/type-c/Kconfig
> > index 02abd74..72b002e 100644
> > --- a/drivers/usb/type-c/Kconfig
> > +++ b/drivers/usb/type-c/Kconfig
> > @@ -12,4 +12,14 @@ config TYPEC_UCSI
> > registers and data structures used to interface with the USB Type-C
> > connectors on a system.
> >
> > +if TYPEC_UCSI
> > +
> > +config TYPEC_UCSI_ACPI
> > + tristate "UCSI ACPI Driver"
> > + depends on ACPI
> > + help
> > + Driver for ACPI enumerated UCSI devices.
>
> Worst help text ever :(
I'm sorry for that. I was not planning to leave it like that. I was
more consearned with the class then these drivers, and forgot finish
these parts.
Thanks,
--
heikki