Re: [PATCH v8 0/3] tty: Introduce software RS485 direction control support
From: Peter Hurley
Date: Wed Feb 10 2016 - 11:28:18 EST
On 02/10/2016 08:24 AM, Matwey V. Kornilov wrote:
> 2016-02-10 19:05 GMT+03:00 Peter Hurley <peter@xxxxxxxxxxxxxxxxxx>:
>> Hi Matwey,
>>
>> On 02/01/2016 10:09 AM, Matwey V. Kornilov wrote:
>>> Changes from v7:
>>> - rework comments to follow guidelines
>>> - minor style changes
>>> Changes from v6:
>>> - minor style changes
>>> - timers are not IRQSAFE now
>>> Changes from v5:
>>> - rs485_emul variable has been renamed to em485 to follow function names convention
>>> Changes from v4:
>>> - Add commit message to 1/3
>>> Changes from v3:
>>> - Completely redesigned.
>>> Changes from v2:
>>> - Introduced SER_RS485_SOFTWARE to show that software implementation is being used
>>> - serial8250_rs485_config is located as required
>>> - Timers are used to implement delay_before and delay_after timeouts
>>>
>>> Signed-off-by: Matwey V. Kornilov <matwey@xxxxxxxxxx>
>>
>> The holdup here is that I'd like to unit test this, which is 3rd on my todo list.
>> Should be done before the end of the week which will be soon enough
>> for this series to make linux-next.
>
> Hi Peter,
>
> Is something required from me?
Not unless my tests identify a problem. I'll let you know.