Re: [RFC][PATCH v3 2/4] printk: do not console_cont_flush() on every jump to again
From: Petr Mladek
Date: Wed Feb 10 2016 - 11:58:40 EST
On Sat 2016-01-23 17:15:11, Sergey Senozhatsky wrote:
> Every jump to `again' label will call console_cont_flush(),
> which is not really something big -- it just adds one extra
> raw_spin_lock_irqsave/raw_spin_unlock_irqrestore. However, to
> keep the previous behaviour we can call console_cont_flush()
> only when `retry' is false -- which happens once, all jumps
> to `again' label have `retry' set to true.
The patch is correct and restores the original behavior, so
Reviewed-by: Petr Mladek <pmladek@xxxxxxxx>
But I would personally omit it. We see the cont buffer earlier
without this patch.
Best Regards,
Petr
PS: I will review the other patches tomorrow.