Re: [PATCH] cifs: fix erroneous return value

[Steve French]

Merged into cifs-2.6.git and added cc: stable

On Wed, Feb 10, 2016 at 11:50 AM, Anton Protopopov
<a.s.protopopov@xxxxxxxxx> wrote:
> The setup_ntlmv2_rsp() function may return positive value ENOMEM instead
> of -ENOMEM in case of kmalloc failure.
>
> Signed-off-by: Anton Protopopov <a.s.protopopov@xxxxxxxxx>
> ---
>  fs/cifs/cifsencrypt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/cifs/cifsencrypt.c b/fs/cifs/cifsencrypt.c
> index afa09fc..e682b36 100644
> --- a/fs/cifs/cifsencrypt.c
> +++ b/fs/cifs/cifsencrypt.c
> @@ -714,7 +714,7 @@ setup_ntlmv2_rsp(struct cifs_ses *ses, const struct nls_table *nls_cp)
>
>         ses->auth_key.response = kmalloc(baselen + tilen, GFP_KERNEL);
>         if (!ses->auth_key.response) {
> -               rc = ENOMEM;
> +               rc = -ENOMEM;
>                 ses->auth_key.len = 0;
>                 goto setup_ntlmv2_rsp_ret;
>         }
> --
> 2.6.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
Thanks,

Steve