Re: [PATCH v4 2/2] mips: Differentiate between 32 and 64 bit ELF header

[Maciej W. Rozycki]

On Thu, 11 Feb 2016, Ralf Baechle wrote:

> > Signed-off-by: Daniel Wagner <daniel.wagner@xxxxxxxxxxxx>
> > Suggested-by: Maciej W. Rozycki <macro@xxxxxxxxxx>
> > Reviewed-by: Maciej W. Rozycki <macro@xxxxxxxxxx>
> > Reported-by: Fengguang Wu <fengguang.wu@xxxxxxxxx>
> 
> Thanks, applied.
> 
> I'm getting a less spectacular warning from gcc 5.2:
> 
>   CC      fs/proc/vmcore.o
> fs/proc/vmcore.c: In function ʽparse_crash_elf64_headersʼ:
> fs/proc/vmcore.c:939:47: warning: initialization from incompatible pointer type [-Wincompatible-pointer-types]

 Yes, the temporaries still need to have their pointed types changed, to 
`Elf32_Ehdr' and `Elf64_Ehdr' respectively, as in the original change.

 I had it mentioned in a WIP version of my review (stating that it would 
verify that the correct type is used by the caller), but then deleted that 
part inadvertently, sigh.

 Daniel, sorry for the extra iteration.

  Maciej