Re: [PATCH v4 5/5] pinctrl: sunxi: Use pin number when calling sunxi_pmx_set
From: Linus Walleij
Date: Thu Feb 11 2016 - 08:31:03 EST
On Tue, Feb 9, 2016 at 3:58 PM, Krzysztof Adamski
<krzysztof.adamski@xxxxxxxxx> wrote:
> sunxi_pmx_set accepts pin number and then calculates offset by
> subtracting pin_base from it. sunxi_pinctrl_gpio_get, on the other hand,
> gets offset so we have to convert it to pin number so we won't get
> negative value in sunxi_pmx_set.
>
> This was only used on A10 so far, where there is only one GPIO chip with
> pin_base set to 0 so it didn't matter. However H3 also requires this
> workaround but have two pinmux sections, triggering problem for PL port.
>
> Signed-off-by: Krzysztof Adamski <k@xxxxxxxx>
> Acked-by: Chen-Yu Tsai <wens@xxxxxxxx>
> Acked-by: Maxime Ripard <maxime.ripard@xxxxxxxxxxxxxxxxxx>
OK applied this version that has Maxime's ACK.
Yours,
Linus Walleij