Re: [RFC v1 6/8] x86/init: use linker table for i386 early setup
From: Luis R. Rodriguez
Date: Thu Feb 11 2016 - 15:07:17 EST
On Wed, Jan 20, 2016 at 1:41 PM, Luis R. Rodriguez
<mcgrof@xxxxxxxxxxxxxxxx> wrote:
> On Wed, Jan 20, 2016 at 1:14 PM, Konrad Rzeszutek Wilk
> <konrad.wilk@xxxxxxxxxx> wrote:
>> On Tue, Dec 15, 2015 at 02:16:35PM -0800, Luis R. Rodriguez wrote:
>>> From: "Luis R. Rodriguez" <mcgrof@xxxxxxxx>
>>>
>>> This also annotates this is only used for PC and
>>> lguest hardware subarchitectures.
>>>
>>> Signed-off-by: Luis R. Rodriguez <mcgrof@xxxxxxxx>
>>
>> On Xen the code path (before this patch) was:
>> xen_start_kernel->i386_start_kernel->i386_default_early_setup
>>
>> and now you remove the i386_default_early_setup call?
>
> No you're right, this should include the Xen subarch as well, thanks for that.
FYI - I've mended this fix into my upcoming v2 series, I've also made
a separate patch to make annotate the XEN subarch on the PV guest boot
path (xen_start_kernel()). While at it, I'll go and also add an
extension of documentation to the subarch based on the conversations
on this thread, and make lguest explicitly use LGUEST subarch rather
than just the digit.
Luis