Re: [PATCH 0/4] mailbox: mailbox-test: support single channel with separate Tx and Rx buffer

From: Lee Jones
Date: Fri Feb 12 2016 - 04:17:33 EST


On Thu, 11 Feb 2016, Sudeep Holla wrote:

> Hi Lee, Jassi,
>
> Assuming mailbox-test was designed to be generic, I am trying to extend
> it to support single channel with separate Tx and Rx buffer. With these
> changes I am able to test arm_mhu driver. However I couldn't understand
> the intention of converting buffer to ASCII hex dump in read method.
> I have a local change to remove that so that it can deal with any data
> in any format(e.g. some protocol format)

Not sure quite what you mean. Hexdump can handle any data? If the
hex value read isn't an ASCII value, a '.' is printed on the right
hand side. What data are you expecting that you can't analyse with
hexdump?

> and userspace can deal with the
> actual interpretation of the data. Let me know your thoughts on that.
>
> Regards,
> Sudeep
>
> Sudeep Holla (4):
> mailbox: mailbox-test: rename driver as generic test driver
> mailbox: mailbox-test: fix the compatible string
> mailbox: mailbox-test: use print_hex_dump_bytes to allow dynamic
> printk
> mailbox: mailbox-test: add support for separate tx/rx buffer with
> single channel
>
> .../devicetree/bindings/mailbox/sti-mailbox.txt | 2 +-
> drivers/mailbox/mailbox-test.c | 50 ++++++++++++----------
> 2 files changed, 29 insertions(+), 23 deletions(-)
>

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog