Re: [PATCH V2] regulator: max8973: add support for junction thermal warning

[Rob Herring]

On Wed, Jan 6, 2016 at 10:07 AM, Laxman Dewangan <ldewangan@xxxxxxxxxx> wrote:
> The driver MAX8973 supports the driver for Maxim PMIC MAX77621.
> MAX77621 supports the  junction temp warning at 120 degC and
> 140 degC which is configurable. It generates alert signal when
> junction temperature crosses these threshold.

Sorry, this one fell thru the cracks.

> MAX77621 does not support the continuous temp monitoring of
> junction temperature. It just report whether junction temperature
> crossed the threshold or not.
>
> Add support to
> - Configure junction temp warning threshold via DT property
>   to generate alert when it crosses the threshold.
> - Add support to interrupt the host from this device when alert
>   occurred.
> - read the junction temp via thermal framework.
>
> Signed-off-by: Laxman Dewangan <ldewangan@xxxxxxxxxx>
> ---
> Changes from v1:
> - Remove irq flags from DT
> - More details about supported temp by MAX77621
>
>  .../bindings/regulator/max8973-regulator.txt       |   5 +
>  drivers/regulator/max8973-regulator.c              | 140 ++++++++++++++++++++-
>  include/linux/regulator/max8973-regulator.h        |   4 +
>  3 files changed, 147 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/regulator/max8973-regulator.txt b/Documentation/devicetree/bindings/regulator/max8973-regulator.txt
> index f80ea2f..93f9939 100644
> --- a/Documentation/devicetree/bindings/regulator/max8973-regulator.txt
> +++ b/Documentation/devicetree/bindings/regulator/max8973-regulator.txt
> @@ -31,6 +31,11 @@ Optional properties:
>                 property is available then etr will be enable default.
>
>  Enhanced transient response (ETR) will affect the configuration of CKADV.
> +-maxim,junction-temp-warning: Junction temp warning on which device generates
> +               warning interrupts. This is in millicelcius.

Please append units: maxim,junction-temp-warning-millicelsius or
perhaps maxim,junction-warn-millicelsius to shorten it a bit.

> +
> +Please note that thermal functionality is only supported on MAX77621. The
> +threshold warning supported by MAX77621 are 120 degC and 140 degC.
>
>  Example:
>