Re: [PATCH v2] net: fec: Add "phy-reset-active-low" property to DT

From: Rob Herring
Date: Fri Feb 12 2016 - 14:44:56 EST


On Fri, Feb 12, 2016 at 9:24 AM, Fabio Estevam <festevam@xxxxxxxxx> wrote:
> On Fri, Feb 12, 2016 at 1:20 PM, Rob Herring <robh@xxxxxxxxxx> wrote:
>
>> This is what the gpio flags are for. Why can't you use that?
>
> This has already been discussed in v1:
> https://lkml.org/lkml/2016/2/8/867

Thanks. That's fine, but that detail should be explained in the
binding. Is there a specific compatible string this can be limited to?
It should also be stated that the GPIO flags should be correct rather
than ignored implying I can put in whatever I want there. Then someday
if no more wrong dtbs are in the wild, it can switch back to using
gpio flags. Also, phy-reset-active-low should be prefixed with "fsl,".

Rob