Re: [PATCH v2 1/4] locking/mutex: Add waiter parameter to mutex_optimistic_spin()
From: Davidlohr Bueso
Date: Sat Feb 13 2016 - 13:15:27 EST
On Sat, 13 Feb 2016, Peter Zijlstra wrote:
Can't see it do that, also, if it were to do that, we'd not be here
since having a waiter would then mean no spinners and no starvation
etc..
I was having a hard time understanding why on earth you didn't see that. And yes
I was also wondering why it was even there... but I was looking at -next, where we
have Ding's original patch b9ce3647b4901071b0dd35d62954a4bb0e5ba1d1.... Paul, could
you drop this patch?
But yeah, I do agree that waiters should also do the mutex_can_spin_on_owner()
check unless I'm missing something subtle from Waiman.
Thanks,
Davidlohr