Re: [PATCH 2/3] tpm: Get rid of chip->pdev
From: Jason Gunthorpe
Date: Sun Feb 14 2016 - 01:57:30 EST
On Sun, Feb 14, 2016 at 07:24:14AM +0200, Jarkko Sakkinen wrote:
> > This should take care of it for all drivers including vtpm.
> >
> > https://github.com/jgunthorpe/linux/commits/for-jarkko
> >
> > At the very least this turns silent use after free into a null pointer
> > oops.
> >
> > We should also discuss if we want to continue to have the driver
> > module locked while /dev/tpmX is open, that is no longer needed for
> > corectness.
>
> I'm happy the patch that was sent before although I didn't give it
> Reviewed-by because it had couple of style errors. If those two
> style errors are the *only* issues I can fix up them.
This patch replaces the get/put_device patch entirely, if Stefan is
happy with it we can just go ahead in this direction for 4.6
There was also a 0day build error on the devname patch, so the whole
series will be reposted.
Jason