Re: [PATCH 7/9] cpufreq: governor: Move rate_mult to struct policy_dbs
From: Viresh Kumar
Date: Mon Feb 15 2016 - 03:56:43 EST
On 15-02-16, 02:20, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
>
> The rate_mult field in struct od_cpu_dbs_info_s is used by the code
> shared with the conservative governor and to access it that code
> has to do an ugly governor type check. However, first of all it
> is ever only used for policy->cpu, so it is per-policy rather than
> per-CPU and second, it is initialized to 1 by cpufreq_governor_start(),
> so if the conservative governor never modifies it, it will have no
> effect on the results of any computations.
>
> For these reasons, move rate_mult to struct policy_dbs_info (as a
> common field).
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
> ---
> drivers/cpufreq/cpufreq_governor.c | 25 +++++++++----------------
> drivers/cpufreq/cpufreq_governor.h | 3 ++-
> drivers/cpufreq/cpufreq_ondemand.c | 23 +++++++++++++++--------
> 3 files changed, 26 insertions(+), 25 deletions(-)
Acked-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
--
viresh