Re: [PATCH 0/4] mailbox: mailbox-test: support single channel with separate Tx and Rx buffer

From: Jassi Brar
Date: Mon Feb 15 2016 - 07:32:00 EST


On Mon, Feb 15, 2016 at 5:47 PM, Sudeep Holla <sudeep.holla@xxxxxxx> wrote:
> Hi Jassi,
>
> On 11/02/16 17:13, Sudeep Holla wrote:
>>
>> Hi Lee, Jassi,
>>
>> Assuming mailbox-test was designed to be generic, I am trying to extend
>> it to support single channel with separate Tx and Rx buffer. With these
>> changes I am able to test arm_mhu driver. However I couldn't understand
>> the intention of converting buffer to ASCII hex dump in read method.
>> I have a local change to remove that so that it can deal with any data
>> in any format(e.g. some protocol format) and userspace can deal with the
>> actual interpretation of the data. Let me know your thoughts on that.
>>
>
> Can you review this ? It would be good to get this in for v4.6
>
Seems simple enough. So once you and Lee are in sync...