Re: [Xen-devel] [PATCH] Fixes to Xen pcifront and pciback (v1)
From: David Vrabel
Date: Mon Feb 15 2016 - 09:38:32 EST
On 15/02/16 14:35, David Vrabel wrote:
> On 11/02/16 21:10, Konrad Rzeszutek Wilk wrote:
>> Hey,
>>
>> These are patches that were developed for the Debian bug
>> 810379 which san Tommi had openned.
>>
>> The issue around from the two XSA fixes - which introduced
>> this regression.
>
> Applied to for-linus-4.6, thanks.
I mean for-linus-4.5.
I also fixed the minor style quibbles.
David
> I rewrote some of the commit messages for clarity. Please only put
> relevant information in them and for regression fixes, make sure it's
> clear what functionality regressed.
>
> e.g. #1 now reads:
>
> Commit 408fb0e5aa7fda0059db282ff58c3b2a4278baa0 (xen/pciback: Don't
> allow MSI-X ops if PCI_COMMAND_MEMORY is not set) prevented enabling
> MSI-X on passed-through virtual functions, because it checked the VF
> for PCI_COMMAND_MEMORY but this is not a valid bit for VFs.
>
> Instead, check the physical function for PCI_COMMAND_MEMORY.
>
> David
>