Re: [PATCH 02/14] clkdev: Remove clk_register_clkdevs()

[Andy Shevchenko]

On Mon, 2016-02-08 at 17:45 -0800, Stephen Boyd wrote:
> Now that we've converted the only caller over to another clkdev
> API, remove this one.
> 

This API didn't feel suitable, good we get rid of it eventually.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>>Â

> Cc: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> Cc: Russell King <linux@xxxxxxxxxxxxxxxx>
> Signed-off-by: Stephen Boyd <sboyd@xxxxxxxxxxxxxx>
> ---
> Âdrivers/clk/clkdev.cÂÂÂ| 27 ---------------------------
> Âinclude/linux/clkdev.h |ÂÂ1 -
> Â2 files changed, 28 deletions(-)
> 
> diff --git a/drivers/clk/clkdev.c b/drivers/clk/clkdev.c
> index 779b6ff0c7ad..ae61f2e57048 100644
> --- a/drivers/clk/clkdev.c
> +++ b/drivers/clk/clkdev.c
> @@ -383,30 +383,3 @@ int clk_register_clkdev(struct clk *clk, const
> char *con_id,
> Â	return cl ? 0 : -ENOMEM;
> Â}
> ÂEXPORT_SYMBOL(clk_register_clkdev);
> -
> -/**
> - * clk_register_clkdevs - register a set of clk_lookup for a struct
> clk
> - * @clk: struct clk to associate with all clk_lookups
> - * @cl: array of clk_lookup structures with con_id and dev_id pre-
> initialized
> - * @num: number of clk_lookup structures to register
> - *
> - * To make things easier for mass registration, we detect error clks
> - * from a previous clk_register() call, and return the error code
> for
> - * those.ÂÂThis is to permit this function to be called immediately
> - * after clk_register().
> - */
> -int clk_register_clkdevs(struct clk *clk, struct clk_lookup *cl,
> size_t num)
> -{
> -	unsigned i;
> -
> -	if (IS_ERR(clk))
> -		return PTR_ERR(clk);
> -
> -	for (i = 0; i < num; i++, cl++) {
> -		cl->clk_hw = __clk_get_hw(clk);
> -		__clkdev_add(cl);
> -	}
> -
> -	return 0;
> -}
> -EXPORT_SYMBOL(clk_register_clkdevs);
> diff --git a/include/linux/clkdev.h b/include/linux/clkdev.h
> index 08bffcc466de..43a8c2e8ac29 100644
> --- a/include/linux/clkdev.h
> +++ b/include/linux/clkdev.h
> @@ -46,7 +46,6 @@ int clk_add_alias(const char *, const char *, const
> char *, struct device *);
> Â
> Âint clk_register_clkdev(struct clk *, const char *, const char *,
> ...)
> Â	__printf(3, 4);
> -int clk_register_clkdevs(struct clk *, struct clk_lookup *, size_t);
> Â
> Â#ifdef CONFIG_COMMON_CLK
> Âint __clk_get(struct clk *clk);

-- 
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy