Re: [RFC PATCH] GPIO/ACPI: DesignWare: Add GPIO-signaled ACPI events support for power button
From: Linus Walleij
Date: Mon Feb 15 2016 - 13:25:28 EST
Mika can you help out looking at this patch. Tell me if you need a copy
of the whole patch, I'm not smart with ACPI.
On Fri, Feb 5, 2016 at 7:25 AM, qiujiang <qiujiang@xxxxxxxxxx> wrote:
> This patch modifies the DesignWare GPIO controller driver to
> support the GPIO-signaled ACPI Events. This is used for power
> button function on ARM server.
>
> To make it work, the _AEI and _EVT object must be defined in
> the corresponding GPIO driver's dsdt table in UEFI. At the same
> time, ACPI daemon component is also necessary.
>
> Signed-off-by: qiujiang <qiujiang@xxxxxxxxxx>
(...)
> --- a/drivers/gpio/gpio-dwapb.c
> +++ b/drivers/gpio/gpio-dwapb.c
> @@ -23,6 +23,11 @@
> #include <linux/spinlock.h>
> #include <linux/platform_data/gpio-dwapb.h>
> #include <linux/slab.h>
> +#include <linux/acpi.h>
> +#include <linux/gpio.h>
You should only need <linux/driver.h>
> +#include "gpiolib.h"
I guess this is for some acpi_gpiochip* functions that ACPI GPIO
drivers need like this:
> + /* Add GPIO-signaled ACPI event support */
> + if (pp->irq)
> + acpi_gpiochip_request_interrupts(&(port->bgc.gc));
Hm, maybe these should be in "gpiolib-acpi.h" or so.
Overall the patch looks sane to me, but I need some ACPI
person to tell.
Yours,
Linus Walleij