Re: [PATCH 1/2] firmware: arm_scpi: add support for 64-bit sensor values
From: Punit Agrawal
Date: Mon Feb 15 2016 - 13:40:13 EST
Sudeep Holla <sudeep.holla@xxxxxxx> writes:
> SCPI specification version 1.1 extended the sensor from 32-bit to 64-bit
> values in order to accommodate new sensor class with 64-bit requirements
>
> Since the SCPI driver sets the higher 32-bit for older protocol version
> to zeros, there's no need to explicitly check the SCPI protocol version
> and the backward compatibility is maintainted.
>
> Cc: Punit Agrawal <punit.agrawal@xxxxxxx>
Thanks for the update to the driver.
Reviewed-by: Punit Agrawal <punit.agrawal@xxxxxxx>
> Signed-off-by: Sudeep Holla <sudeep.holla@xxxxxxx>
> ---
> drivers/firmware/arm_scpi.c | 8 +++++---
> drivers/hwmon/scpi-hwmon.c | 6 +++---
> include/linux/scpi_protocol.h | 2 +-
> 3 files changed, 9 insertions(+), 7 deletions(-)
>
> Hi Guenter,
>
> Since I have couple of other fixes for SCPI driver, if you can provide
> your ACKs to this couple of patches after your review, I can take all of
> them together via ARM-SoC if that's fine with you.
>
> Regards,
> Sudeep
>
[...]