RE: [PATCH v3 1/2] bluetooth: btmrvl: register platform specific driver

[Amitkumar Karwar]

Hi Rob,

> From: Rob Herring [mailto:robh@xxxxxxxxxx]
> Sent: Tuesday, February 09, 2016 3:35 AM
> To: Amitkumar Karwar
> Cc: linux-bluetooth@xxxxxxxxxxxxxxx; Nishant Sarmukadam;
> wnhuang@xxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; Xinming Hu
> Subject: Re: [PATCH v3 1/2] bluetooth: btmrvl: register platform
> specific driver
> 
> On Mon, Feb 08, 2016 at 02:27:10AM -0800, Amitkumar Karwar wrote:
> > From: Xinming Hu <huxm@xxxxxxxxxxx>
> >
> > Platform device and driver provide easy way to interact with
> > device-tree-enabled system.
> >
> > This patch registers platform driver and reorganise existing device
> > tree specific code.
> >
> > Signed-off-by: Xinming Hu <huxm@xxxxxxxxxxx>
> > Signed-off-by: Amitkumar Karwar <akarwar@xxxxxxxxxxx>
> > ---
> > v3: Add NULL check for 'btmrvl_plt_dev'
> > ---
> >  Documentation/devicetree/bindings/btmrvl.txt |  8 ++--
> 
> This needs to move somewhere else.
> 
> >  drivers/bluetooth/Makefile                   |  1 +
> >  drivers/bluetooth/btmrvl_drv.h               | 16 ++++++++
> >  drivers/bluetooth/btmrvl_main.c              |  8 +++-
> >  drivers/bluetooth/btmrvl_platform.c          | 60
> ++++++++++++++++++++++++++++
> >  5 files changed, 88 insertions(+), 5 deletions(-)  create mode 100644
> > drivers/bluetooth/btmrvl_platform.c
> >
> > diff --git a/Documentation/devicetree/bindings/btmrvl.txt
> > b/Documentation/devicetree/bindings/btmrvl.txt
> > index 58f964b..25b804b 100644
> > --- a/Documentation/devicetree/bindings/btmrvl.txt
> > +++ b/Documentation/devicetree/bindings/btmrvl.txt
> > @@ -3,7 +3,7 @@ btmrvl
> >
> >  Required properties:
> >
> > -  - compatible : must be "btmrvl,cfgdata"
> > +  - compatible : must be "marvell,btmrvl"
> 
> While the new name is less worse than the old one, I'm not inclined to
> take any changes for this binding because it is problematic. Given you
> don't care this is an incompatible change, then the binding can be
> completely redone.
> 
> It should reflect the actual chip name (e.g. sd8???) and be a child node
> of its connection to the host (a UART). See UART slave discussions.
> 
> >

I have corrected the name as per your inputs for WLAN driver and submitted updated version.
The connection here is not via UART. It's through SDIO bus. We will add it as a child node of MMC in DTSI config file.
Let me know if you have any further comments for the improvements.

Regards,
Amitkumar