Re: [PATCH v3 5/5] dell-wmi: support Dell Inspiron M5110

From: MichaÅ KÄpieÅ
Date: Tue Feb 16 2016 - 17:03:21 EST


> > /* Shortcut and audio panel keys */
> > { KE_KEY, 0xe025, { KEY_PROG4 } },
> > { KE_IGNORE, 0xe026, { KEY_RESERVED } },
> > + { KE_KEY, 0xe029, { KEY_PROG4 } },
>
> Hi! Above comment (Shortcut and audio panel keys) is not relevant for
> this 0xe029, right?

I believe it is relevant. The commit which added that comment
(f1566f0d) was made by Seth Forshee to support Dell XPS L502X. The term
"shortcut key" is used in the bug report linked from that commit [1],
but the manual for that model [2] describes the hotkey in question as
"Instant launch control" (page 43), so I believe both Seth's commit and
my patch refer to the same thing.

[1] https://bugs.launchpad.net/ubuntu/+source/linux/+bug/815914/comments/6
[2] http://downloads.dell.com/Manuals/all-products/esuprt_laptop/esuprt_xps_laptop/xps-l502x_setup%20guide_en-us.pdf

--
Best regards,
MichaÅ KÄpieÅ