Re: [PATCH 1/2] cpufreq: ondemand: Simplify od_update() slightly

From: Viresh Kumar
Date: Wed Feb 17 2016 - 00:12:44 EST


On 16-02-16, 21:00, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
>
> Drop some lines of code from od_update() by arranging the statements
> in there in a more logical way.
>
> No functional changes.
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
> ---
> drivers/cpufreq/cpufreq_ondemand.c | 11 ++++-------
> 1 file changed, 4 insertions(+), 7 deletions(-)
>
> Index: linux-pm/drivers/cpufreq/cpufreq_ondemand.c
> ===================================================================
> --- linux-pm.orig/drivers/cpufreq/cpufreq_ondemand.c
> +++ linux-pm/drivers/cpufreq/cpufreq_ondemand.c
> @@ -175,14 +175,11 @@ static void od_update(struct cpufreq_pol
> /* No longer fully busy, reset rate_mult */
> policy_dbs->rate_mult = 1;
>
> - if (!od_tuners->powersave_bias) {
> - __cpufreq_driver_target(policy, freq_next,
> - CPUFREQ_RELATION_C);
> - return;
> - }
> + if (od_tuners->powersave_bias)
> + freq_next = od_ops.powersave_bias_target(policy,
> + freq_next,
> + CPUFREQ_RELATION_L);
>
> - freq_next = od_ops.powersave_bias_target(policy, freq_next,
> - CPUFREQ_RELATION_L);
> __cpufreq_driver_target(policy, freq_next, CPUFREQ_RELATION_C);
> }
> }

Acked-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>

--
viresh