Re: [PATCH v2 3/7] ibmvscsi: Replace magic values in set_adpater_info() with defines

[Johannes Thumshirn]

On Tue, Feb 16, 2016 at 10:03:24PM -0500, Martin K. Petersen wrote:
> >>>>> "Tyrel" == Tyrel Datwyler <tyreld@xxxxxxxxxxxxxxxxxx> writes:
> 
> >> Is there some reason you didn't carry the review tag over from this:
> >> 
> >> http://mid.gmane.org/20160204084459.GW27969@xxxxxxxxxxxxxxxxx
> >> 
> >> ?
> >> 
> >> James
> 
> Tyrel> The patch is slightly changed from v1. A define for AIX os type
> Tyrel> was added as mentioned in the cover letter v2 changes, and I
> Tyrel> moved the defines to the mad_adapter_info_data structure around
> Tyrel> the fields they apply.
> 
> Johannes: Mind checking this out?

I'm sorry I though I already did.

Reviewed-by: Johannes Thumshirn <jthumshirn@xxxxxxx>

> 
> https://patchwork.kernel.org/patch/8276101/
> 
> -- 
> Martin K. Petersen	Oracle Linux Engineering

-- 
Johannes Thumshirn                                          Storage
jthumshirn@xxxxxxx                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850