Re: [PATCH v1] GPIO/ACPI: DesignWare: Add GPIO-signaled ACPI events support for power button

[Mika Westerberg]

On Wed, Feb 17, 2016 at 03:28:10PM +0800, qiujiang wrote:
> This patch modifies the DesignWare GPIO controller driver to
> support the GPIO-signaled ACPI Events. This is used for power
> button function on ARM server.
> 
> To make it work, the _AEI and _EVT object must be defined in
> the corresponding GPIO driver's dsdt table in UEFI as follow:
> 
> Device(GPI0) {
>         Name(_HID, "HISI0181")
> 	Name(_ADR, 0) // _ADR: Address
>         Name(_UID, 0)
> 
> 	Name (_CRS, ResourceTemplate ()  {
> 		Memory32Fixed (ReadWrite, 0x802e0000, 0x10000)
> 		Interrupt (ResourceConsumer, Level, ActiveHigh,
> 		Exclusive,,,) {344}
> 	})
> 
> 	Device(PRTa) {
> 		Name (_DSD, Package () {
> 			Package () {
> 				Package () {"reg",0},
> 				Package () {"snps,nr-gpios",32},
> 		}
> 		})
> 	}
> 
> 	Name (_AEI, ResourceTemplate () {
> 		GpioInt(Edge, ActiveLow, ExclusiveAndWake, PullUp, ,
> 		" \\_SB.GPI0") {8}
> 	})
> 
> 	Method (_E08, 0x0, NotSerialized) {
> 		Notify (\_SB.PWRB, 0x80)
> 	}
> }
> 
> Signed-off-by: qiujiang <qiujiang@xxxxxxxxxx>

ACPI parts look fine by me.

Reviewed-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>