Re: [tpmdd-devel] [PATCH] tpm_crb: fix bad name pointer usage with struct resource

[Jarkko Sakkinen]

On Tue, Feb 16, 2016 at 09:52:19PM -0700, Jason Gunthorpe wrote:
> On Wed, Feb 17, 2016 at 02:27:54AM +0200, Jarkko Sakkinen wrote:
> > -	if (acpi_dev_resource_memory(ares, &res))
> > +	if (acpi_dev_resource_memory(ares, &res)) {
> > +		res.name = NULL;
> 
> What? How is this not a bug in acpi_dev_resource_memory? Maybe it
> needs to memcpy into devm allocated memory instead, but I'm confused
> how/why/when acpi could free name.
> 
> The same code exists in tpm_tis as well.

That was the only way to fix the garbage issue. I would keep things
this way for Linux 4.5.

/Jarkko