[PATCH] fs crypto: fix ifnullfree.cocci warnings

From: Julia Lawall
Date: Wed Feb 17 2016 - 08:33:09 EST


NULL check before some freeing functions is not needed.

Generated by: scripts/coccinelle/free/ifnullfree.cocci

Signed-off-by: Fengguang Wu <fengguang.wu@xxxxxxxxx>
Signed-off-by: Julia Lawall <julia.lawall@xxxxxxx>

---

crypto.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)

--- a/fs/crypto/crypto.c
+++ b/fs/crypto/crypto.c
@@ -414,8 +414,7 @@ static void fscrypt_destroy(void)
list_for_each_entry_safe(pos, n, &fscrypt_free_ctxs, free_list)
kmem_cache_free(fscrypt_ctx_cachep, pos);
INIT_LIST_HEAD(&fscrypt_free_ctxs);
- if (fscrypt_bounce_page_pool)
- mempool_destroy(fscrypt_bounce_page_pool);
+ mempool_destroy(fscrypt_bounce_page_pool);
fscrypt_bounce_page_pool = NULL;
}

@@ -500,9 +499,7 @@ void __exit fscrypt_exit(void)

if (fscrypt_read_workqueue)
destroy_workqueue(fscrypt_read_workqueue);
- if (fscrypt_ctx_cachep)
- kmem_cache_destroy(fscrypt_ctx_cachep);
- if (fscrypt_info_cachep)
- kmem_cache_destroy(fscrypt_info_cachep);
+ kmem_cache_destroy(fscrypt_ctx_cachep);
+ kmem_cache_destroy(fscrypt_info_cachep);
}
module_exit(fscrypt_exit);