Re: [PATCH 1/1] of/overlay: of overlay callbacks

[Moritz Fischer]

Hi Alan,

a couple of nits below.

On Wed, Feb 17, 2016 at 9:41 AM, Alan Tull <atull@xxxxxxxxxxxxxxxxxxxxx> wrote:

>
> +/*
> + * Send overlay callbacks to handlers that match.  This call is blocking.  In
Can we make this 'Invoke' instead of send?

> @@ -370,6 +448,13 @@ int of_overlay_create(struct device_node *tree)
>                 goto err_free_idr;
>         }
>
> +       err = send_overlay_callbacks(ov, OF_OVERLAY_PRE_APPLY);

Again ... maybe invoke ;-)

> +       if (err < 0) {
> +               pr_err("%s: Pre apply handler failed (err=%d)\n",
> +                      __func__, err);
> +               goto err_free_idr;
> +       }
> +
>         /* apply the overlay */
>         err = of_overlay_apply(ov);
>         if (err) {
> @@ -389,6 +474,8 @@ int of_overlay_create(struct device_node *tree)
>         /* add to the tail of the overlay list */
>         list_add_tail(&ov->node, &ov_list);
>
> +       send_overlay_callbacks(ov, OF_OVERLAY_POST_APPLY);

And again :)

> diff --git a/include/linux/of.h b/include/linux/of.h
> index dc6e396..def9481 100644
> --- a/include/linux/of.h
> +++ b/include/linux/of.h
> @@ -101,9 +101,33 @@ static inline int of_node_is_attached(struct device_node *node)
>         return node && node->kobj.state_in_sysfs;
>  }
>
> +/* Callback types */
> +#define OF_OVERLAY_PRE_APPLY   (0)
> +#define OF_OVERLAY_POST_APPLY  (1)
> +#define OF_OVERLAY_PRE_REMOVE  (2)
> +#define OF_OVERLAY_POST_REMOVE (3)

Can we make this an enum?

Cheers,

Moritz