[PATCH] IB/rxe: fix compare_const_fl.cocci warnings
From: Julia Lawall
Date: Thu Feb 18 2016 - 08:06:35 EST
Move constants to the right of binary operators.
Generated by: scripts/coccinelle/misc/compare_const_fl.cocci
CC: Kamal Heib <kamalh@xxxxxxxxxxxx>
Signed-off-by: Fengguang Wu <fengguang.wu@xxxxxxxxx>
Signed-off-by: Julia Lawall <julia.lawall@xxxxxxx>
---
The constants on the right look a bit nicer. Another possibility would be
!!.
tree: https://github.com/dledford/linux.git rxe-v2
head: bc91f3e63df667e8da8894a51149a2fc9acf0e71
commit: 30e5584cf453cd90bbcd3ebb5f3e774c0195dd83 [30/31] IB/rxe: Add
Soft-RoCE to kbuild and makefiles
rxe_mr.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- a/drivers/staging/rdma/rxe/rxe_mr.c
+++ b/drivers/staging/rdma/rxe/rxe_mr.c
@@ -43,8 +43,8 @@ static u8 rxe_get_key(void)
key = key << 1;
- key |= (0 != (key & 0x100)) ^ (0 != (key & 0x10))
- ^ (0 != (key & 0x80)) ^ (0 != (key & 0x40));
+ key |= ((key & 0x100) != 0) ^ ((key & 0x10) != 0)
+ ^ ((key & 0x80) != 0) ^ ((key & 0x40) != 0);
key &= 0xff;