Re: [PATCH v2 1/2] mpt3sas: Free memory pools before retrying to allocate with different value.

From: Johannes Thumshirn
Date: Thu Feb 18 2016 - 08:10:28 EST


On Thu, Feb 18, 2016 at 01:54:02PM +0100, Tomas Henzl wrote:
> On 18.2.2016 09:39, Suganath Prabu Subramani wrote:
> > From: Suganath prabu Subramani <suganath-prabu.subramani@xxxxxxxxxxxxx>
> >
> > Deallocate resources before reallocating of the same in retry_allocation
> > path of _base_allocate_memory_pools()
> >
> > Signed-off-by: Suganath prabu Subramani <suganath-prabu.subramani@xxxxxxxxxxxxx>
> > Signed-off-by: Chaitra P B <chaitra.basappa@xxxxxxxxxxxx>
> > ---
> > drivers/scsi/mpt3sas/mpt3sas_base.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt3sas/mpt3sas_base.c
> > index afdb13a..5bbbbf2 100644
> > --- a/drivers/scsi/mpt3sas/mpt3sas_base.c
> > +++ b/drivers/scsi/mpt3sas/mpt3sas_base.c
> > @@ -3414,6 +3414,7 @@ _base_allocate_memory_pools(struct MPT3SAS_ADAPTER *ioc, int sleep_flag)
> > goto out;
> > retry_sz = 64;
> > ioc->hba_queue_depth -= retry_sz;
> > + _base_release_memory_pools(ioc);
> > goto retry_allocation;
> > }
> >
>
> Reviewed-by: Tomas Henzl <thenzl@xxxxxxxxxx>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html

Reviewed-by: Johannes Thumshirn <jthumshirn@xxxxxxx>
--
Johannes Thumshirn Storage
jthumshirn@xxxxxxx +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850