Re: [PATCH V6 1/2] regulator: Add document for MT6323 regulator

[John Crispin]

On 18/02/2016 15:36, Rob Herring wrote:
> On Wed, Feb 17, 2016 at 12:37:35PM +0100, John Crispin wrote:
>> Signed-off-by: John Crispin <blogic@xxxxxxxxxxx>
>> Cc: devicetree@xxxxxxxxxxxxxxx
>>
>> ---
>> Changes in V6
>> * remove the compatible string
>>
>> Changes in V5
>> * regulator vs regulators
>>
>> Changes in V4
>> * regulator is a subnode and not a property
>>
>>  .../bindings/regulator/mt6323-regulator.txt        |  241 ++++++++++++++++++++
>>  1 file changed, 241 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/regulator/mt6323-regulator.txt
>>
>> diff --git a/Documentation/devicetree/bindings/regulator/mt6323-regulator.txt b/Documentation/devicetree/bindings/regulator/mt6323-regulator.txt
>> new file mode 100644
>> index 0000000..67c0780
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/regulator/mt6323-regulator.txt
>> @@ -0,0 +1,241 @@
>> +Mediatek MT6323 Regulator Driver
>> +
>> +All voltage regulators are defined as subnodes of the regulators node. A list
>> +of regulators provided by this controller are defined as subnodes of the
>> +drivers node. Each regulator is named according to its regulator type,
> 
> s/drivers/PMIC's/
> 
>> +buck_<name> and ldo_<name>. The definition for each of these nodes is defined
>> +using the standard binding for regulators at
>> +Documentation/devicetree/bindings/regulator/regulator.txt.
>> +
>> +The valid names for regulators are::
>> +BUCK:
>> +  buck_vproc, buck_vsys, buck_vpa
>> +LDO:
>> +  ldo_vtcxo, ldo_vcn28, ldo_vcn33_bt, ldo_vcn33_wifi, ldo_va, ldo_vcama,
>> +  ldo_vio28, ldo_vusb, ldo_vmc, ldo_vmch, ldo_vemc3v3, ldo_vgp1, ldo_vgp2,
>> +  ldo_vgp3, ldo_vcn18, ldo_vsim1, ldo_vsim2, ldo_vrtc, ldo_vcamaf, ldo_vibr,
>> +  ldo_vrf18, ldo_vm, ldo_vio18, ldo_vcamd, ldo_vcamio
>> +
>> +Example:
>> +
>> +	pmic: mt6323 {
>> +		compatible = "mediatek,mt6323";
>> +
>> +		mt6323regulator: regulators {
>> +			compatible = "mediatek,mt6323-regulator";
> 
> Still have the compatible here...
> 
> Otherwise:
> 
> Acked-by: Rob Herring <robh@xxxxxxxxxx>
> 

grml, i only removed one of the compat strings and did not notice there
are two. do you want me to send a fixup that you can fold into the one
you already merged or do you want me to resend just this one patch with
the fix applied ?

	John


> 
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@xxxxxxxxxxxxxxxxxxx
> http://lists.infradead.org/mailman/listinfo/linux-mediatek
>