Re: [PATCH v1] tty: serial: Use GFP_ATOMIC instead of GFP_KERNEL in serial8250_em485_init()

From: Andy Shevchenko
Date: Thu Feb 18 2016 - 15:22:01 EST


On Thu, Feb 18, 2016 at 8:47 PM, Matwey V. Kornilov <matwey@xxxxxxxxxx> wrote:
> serial8250_em485_init() is supposed to be protected with
> p->port.lock spinlock.
> This may lead to issues when kmalloc sleeps, so it is better to use
> GFP_ATOMIC in this spinlocked context.
>
> Fixes: e490c9144cfa ("tty: Add software emulated RS485 support for 8250")
> Reported-by: <torso.nafi@xxxxxxxxx>

Hmm... Can't we put Cyrillic characters to tags as name of a person?

--
With Best Regards,
Andy Shevchenko