Re: [PATCH 1/1] intel_pstate: Increase hold-off time before busyness is scaled

[Pandruvada, Srinivas]

On Thu, 2016-02-18 at 20:43 +0100, Rafael J. Wysocki wrote:
> Hi Mel,
> 
> On Thu, Feb 18, 2016 at 12:11 PM, Mel Gorman
> <mgorman@xxxxxxxxxxxxxxxxxxx> wrote:
> 
> [cut]
> 
> > 
> > Signed-off-by: Mel Gorman <mgorman@xxxxxxxxxxxxxxxxxxx>
> > ---
> > Âdrivers/cpufreq/intel_pstate.c | 2 +-
> > Â1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/cpufreq/intel_pstate.c
> > b/drivers/cpufreq/intel_pstate.c
> > index cd83d477e32d..54250084174a 100644
> > --- a/drivers/cpufreq/intel_pstate.c
> > +++ b/drivers/cpufreq/intel_pstate.c
> > @@ -999,7 +999,7 @@ static inline int32_t
> > get_target_pstate_use_performance(struct cpudata *cpu)
> > ÂÂÂÂÂÂÂÂsample_time = pid_params.sample_rate_msÂÂ* USEC_PER_MSEC;
> > ÂÂÂÂÂÂÂÂduration_us = ktime_us_delta(cpu->sample.time,
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂcpu->last_sample_time);
> > -ÂÂÂÂÂÂÂif (duration_us > sample_time * 3) {
> > +ÂÂÂÂÂÂÂif (duration_us > sample_time * 12) {
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂsample_ratio = div_fp(int_tofp(sample_time),
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂint_tofp(duration_us));
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂcore_busy = mul_fp(core_busy, sample_ratio);
> > --
> 
> I've been considering making a change like this, but I wasn't quite
> sure how much greater the multiplier should be, so I've queued this
> one up for 4.6.
> 
We need to test power impact on different server workloads. So please
hold on.
We have server folks complaining that we already consume too much
power.

Thanks,
Srinivas

> That said please note that we're planning to make one significant
> change to intel_pstate in the 4.6 cycle that's very likely to affect
> your results.
> 
> It is currently present in linux-next (commit 402c43ed2d74 "cpufreq:
> intel_pstate: Replace timers with utilization update callbacks" in
> the
> linux-next branch of the linux-pm.git tree, that depends on commit
> fe7034338ba0 "cpufreq: Add mechanism for registering utilization
> update callbacks" in the same branch).ÂÂAlso you can just pull from
> the pm-cpufreq-test branch in linux-pm.git, but that contains much
> more material.
> 
> Thanks,
> Rafael
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pm"
> in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info atÂÂhttp://vger.kernel.org/majordomo-info.html