Re: [PATCH 1/2] staging: fsl-mc: Do not allow building as a module

From: Greg Kroah-Hartman
Date: Thu Feb 18 2016 - 23:36:42 EST


On Thu, Feb 18, 2016 at 03:02:30PM +0100, Thierry Reding wrote:
> On Mon, Feb 15, 2016 at 02:22:22PM +0100, Thierry Reding wrote:
> > From: Thierry Reding <treding@xxxxxxxxxx>
> >
> > This driver uses functionality (MSI IRQ domain) whose symbols aren't
> > exported, and hence the modular build fails. While arguably there might
> > be reasons to make these symbols available to modules, that change would
> > be fairly involved and the set of exported functions should be carefully
> > auditioned. Fix the build failure for now by marking the driver boolean.
> >
> > Cc: J. German Rivera <German.Rivera@xxxxxxxxxxxxx>
> > Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> > Signed-off-by: Thierry Reding <treding@xxxxxxxxxx>
> > ---
> > drivers/staging/fsl-mc/bus/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Sorry for being pushy, but this has had allmodconfig builds broken in
> linux-next for a couple of days now. The driver has been marked BROKEN
> now in linux-next to remedy that, but having proper fixes seems better
> than that.

Sorry for the delay, now merged, thanks.

greg k-h