Re: [PATCH] ehea: Drop owner assignment from platform_driver
From: Thadeu Lima de Souza Cascardo
Date: Fri Feb 19 2016 - 06:45:23 EST
On Fri, Feb 19, 2016 at 04:52:19PM +0530, Amitoj Kaur Chawla wrote:
> platform_driver does not need to set an owner, it will be populated by
> the driver core.
>
> Generated-by: scripts/coccinelle/api/platform_no_drv_owner.cocci
>
> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@xxxxxxxxx>
> ---
> drivers/net/ethernet/ibm/ehea/ehea_main.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/ibm/ehea/ehea_main.c b/drivers/net/ethernet/ibm/ehea/ehea_main.c
> index 2a0dc12..d4b022f 100644
> --- a/drivers/net/ethernet/ibm/ehea/ehea_main.c
> +++ b/drivers/net/ethernet/ibm/ehea/ehea_main.c
> @@ -127,7 +127,6 @@ static const struct of_device_id ehea_device_table[] = {
> static struct platform_driver ehea_driver = {
> .driver = {
> .name = "ehea",
> - .owner = THIS_MODULE,
> .of_match_table = ehea_device_table,
> },
> .probe = ehea_probe_adapter,
> --
> 1.9.1
>
NACK.
ehea does not use platform_driver_register, it uses
ibmebus_register_driver, which does not set owner.
Cascardo.