Re: [RFC PATCH 12/20] PKCS#7: Make the signature a pointer rather than embedding it [ver #2]

[David Howells]

Mimi Zohar <zohar@xxxxxxxxxxxxxxxxxx> wrote:

> > Point to the public_key_signature struct from the pkcs7_signed_info struct
> > rather than embedding it.  This makes it easier to have it take an
> > arbitrary number of MPIs in future.
> 
> Just a reminder ...
> 
> Reviewing patches isn't easy no matter how well written and documented,
> especially large patch sets.   For this reason, patch sets should be
> limited to the patches that are required to accomplish the patch set
> goal.  In this case, that goal is to change  "how certificates/keys are
> determined to be trusted."
> 
> Although this patch is straight forward, the patch description should
> include a reason for including this patch in this patch set.   Is having
> an arbitrary number of MPIs included in this patch set?  Could this
> patch be deferred?

Actually, this may be changed with the advent of Tadeusz's patches.

David