Re: [PATCH] uapi: update install list after nvme.h rename

From: Jens Axboe
Date: Fri Feb 19 2016 - 17:38:10 EST


On 02/19/2016 03:23 PM, Mario Limonciello wrote:


On 01/14/2016 02:26 AM, Jiri Slaby wrote:
On 01/14/2016, 02:17 AM, Mike Frysinger wrote:
On 12 Jan 2016 09:45, Jiri Slaby wrote:
On 01/11/2016, 02:14 AM, Mike Frysinger wrote:
Commit 9d99a8dda154 ("nvme: move hardware structures out of the
uapi version of nvme.h") renamed nvme.h to nvme_ioctl.h, but
the uapi list still refers to nvme.h. People trying to install
the headers hit a failure as the header no longer exists.

Wouldn't reverting the rename be nicer to userspace? So that the
filename is preserved and anybody who #included nvme.h still can
do so?

i have no opinion on either route

Can someone with authority please decide on what to do about this?
It's wrecking havoc in userspace right now on stuff that needs nvme.h.

The patch is in Linus' tree, and it was marked stable as well. So stable will pick it up, when the next 4.4-stable is spun.

--
Jens Axboe