Re: [PATCH 1/1] gpio: add devm_ apis for gpio_chip_add and remove

[Laxman Dewangan]

On Tuesday 16 February 2016 08:33 PM, Linus Walleij wrote:
> On Mon, Feb 15, 2016 at 2:17 PM, Laxman Dewangan <ldewangan@xxxxxxxxxx> wrote:
>
> > Add device managed APIs devm_gpiochip_add_data() and
> > devm_gpiochip_remove() for the APIs gpiochip_add_data()
> > and gpiochip_remove().
> >
> > This helps in reducing code in error path and sometimes
> > removal of .remove callback for driver unbind.
> >
> > Signed-off-by: Laxman Dewangan <ldewangan@xxxxxxxxxx>
> I like the looks of this.
>
> One comment: you must also patch
> Documentation/driver-model/devres.txt

Sure,

> Will you also follow up with a massive patch set making use of
> this new API? I feel bad about merging an API if it's not used.
>
> Thanks for only supporting this for the new _data() function.
Yes, I have planned for this to use this new API. This is just for 
getting review whether fine or not to have devm_* APIs so that I can 
make changes on rest of driver to use this new APIs.