Re: [PATCH] f2fs: Introduce lifetime write IO statistics

[Pavel Machek]

Hi!

> From: Shuoran Liu <liushuoran@xxxxxxxxxx>
> 
> Signed-off-by: Shuoran Liu <liushuoran@xxxxxxxxxx>
> Signed-off-by: Pengyang Hou <houpengyang@xxxxxxxxxx>

> --- a/fs/f2fs/checkpoint.c
> +++ b/fs/f2fs/checkpoint.c
> @@ -921,6 +921,10 @@ static int do_checkpoint(struct f2fs_sb_info *sbi, struct cp_control *cpc)
>  	int cp_payload_blks = __cp_payload(sbi);
>  	block_t discard_blk = NEXT_FREE_BLKADDR(sbi, curseg);
>  	bool invalidate = false;
> +	struct super_block *sb = sbi->sb;
> +	struct curseg_info *seg_i = CURSEG_I(sbi, CURSEG_HOT_NODE);
> +	__u64 kbytes_written;
> +

No need to __prefix in kernel.

> diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h

> diff --git a/include/linux/f2fs_fs.h b/include/linux/f2fs_fs.h
> index e59c3be..05ae034 100644
> --- a/include/linux/f2fs_fs.h
> +++ b/include/linux/f2fs_fs.h
> @@ -387,6 +387,11 @@ struct sit_journal {
>  	__u8 reserved[SIT_JOURNAL_RESERVED];
>  } __packed;
>  
> +struct f2fs_extra_info {
> +	__le64 kbytes_written;
> +	__u8 reserved[SUM_JOURNAL_SIZE - 10];
> +} __packed;
> +

Unless this is exported to userspace, no need for __ here, either.

(Would it make sense to store bytes_written, as it is not going to
overflow, anyway?)

Is this going to be exported to userspace somehow?

									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html