Re: [PATCH 3/6] perf, tools, stat: Support metrics in --per-core/socket mode
From: Jiri Olsa
Date: Sun Feb 21 2016 - 12:19:17 EST
On Wed, Feb 17, 2016 at 02:44:02PM -0800, Andi Kleen wrote:
SNIP
>
> perf_stat__print_shadow_stats(counter, uval,
> stat_config.aggr_mode == AGGR_GLOBAL ? 0 :
> - cpu_map__id_to_cpu(id),
> + first_shadow_cpu(counter, id),
> &out);
> -
> if (!csv_output) {
> print_noise(counter, noise);
> print_running(run, ena);
> }
> }
>
> +static void aggr_update_shadow(void)
> +{
> + int cpu, cpu2, s2, id, s;
> + u64 val;
> + struct perf_evsel *counter;
> +
> + for (s = 0; s < aggr_map->nr; s++) {
> + id = aggr_map->map[s];
> + evlist__for_each(evsel_list, counter) {
> + val = 0;
> + for (cpu = 0; cpu < perf_evsel__nr_cpus(counter); cpu++) {
> + cpu2 = perf_evsel__cpus(counter)->map[cpu];
> + s2 = aggr_get_id(evsel_list->cpus, cpu2);
I think you need to pass cpu's 'idx' into aggr_get_id,
because it will do evsel_list->cpus[cpu2] for you
jirka