Re: [PATCH] Btrfs: ctree: added lines after variable declarations

From: Joe Perches
Date: Sun Feb 21 2016 - 19:07:51 EST


On Mon, 2016-02-22 at 01:01 +0100, Philippe Loctaux wrote:
> Is there no need of additional blank line here particulary
> or in all lines that I changed?

Please don't top post and just here.
> On Sun, Feb 21, 2016 at 03:53:04PM -0800, Joe Perches wrote:
> > On Mon, 2016-02-22 at 00:46 +0100, Philippe Loctaux wrote:
> > > Added lines after variable declarations, fixing 22 checkpatch warnings.
> > []
> > > diff --git a/fs/btrfs/ctree.c b/fs/btrfs/ctree.c
> > []
> > > @@ -4592,6 +4610,7 @@ void btrfs_truncate_item(struct btrfs_root *root, struct btrfs_path *path,
> > >         data_end, old_data_start + new_size - data_end);
> > >   } else {
> > >   struct btrfs_disk_key disk_key;
> > > +
> > >   u64 offset;
> >
> > Overzealous here.
> > No additional blank line required.