Re: [PATCH] rtlwifi: pass struct rtl_stats by reference as it is more efficient

From: Colin Ian King
Date: Mon Feb 22 2016 - 05:16:28 EST


On 22/02/16 06:51, Alexander Stein wrote:
> On Saturday 20 February 2016 22:10:27, Colin King wrote:
>> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>>
>> passing rtl_stats by value is inefficient; the structure is over 300
>> bytes in size and generally just one field (packet_report_type)
>> is being accessed, so the pass by value is a relatively large overhead.
>> This change just affects just the rx_command_packet calls.
>
> Why not using a const pointer?

const struct rtl_stats *const status?

>
> Best regards,
> Alexander
>