Re: [PATCH v6 10/12] arm-cci: CCI-500: Work around PMU counter writes

From: Mark Rutland
Date: Mon Feb 22 2016 - 10:16:32 EST


A couple more comments for things i just realised:

> + /*
> + * Now that all the counters are disabled, we can safely turn the PMU on,
> + * without syncing the status of the counters
> + */
> + __cci_pmu_enable(cci_pmu, CCI_CNTRS_NOSYNC);

As per my other comment, __cci_pmu_enable_nosync(cci_pmu) would be
preferable.

[...]

> + pmu_write_counter(cci_pmu,
> + (u32)local64_read(&event->hw.prev_count), i);

That cast can go.

Mark.