Re: [PATCH 1/1] of/overlay: of overlay callbacks

[Pantelis Antoniou]

Hi Rob,

> On Feb 22, 2016, at 04:55 , Rob Herring <robh@xxxxxxxxxx> wrote:
> 
> On Wed, Feb 17, 2016 at 11:41:25AM -0600, Alan Tull wrote:
>> Add overlay callback functionality.
>> 
>> When DT overlays are being added, some drivers/subsystems
>> will want to know about the changes before they go into the
>> live tree.  Similarly there is a need for post-remove
>> callbacks.
>> 
>> Each handler is registered with a of_device_id.  When
>> an overlay target matches a handler's id, the handler
>> gets called.
>> 
>> The following 4 cases are handled: pre-apply, post-apply,
>> pre-remove, and post-remove.
> 
> So I know I suggested maybe not using notifiers, but this ends up just 
> looking like notifiers, so we might as well use them unless we somehow 
> change the flow. You would just need to add pre-apply and pre-remove 
> in of_attach_node and of_detach_node, right?
> 


I agree those look just like notifiers. We could just update the notifier
logic to handle this case.

Am I missing something else?


> Rob

Regards

â Pantelis