Re: [PATCH 08/10] x86/xsaves: Fix PTRACE frames for XSAVES

[Yu-cheng Yu]

On Mon, Feb 22, 2016 at 02:19:05PM -0800, Dave Hansen wrote:
> On 02/22/2016 12:48 PM, Yu-cheng Yu wrote:
> > It should have been:
> > 
> > 	xsave->header.xfeatures = xfeatures |
> > 		(xsave->header.xfeatures & XFEATURE_MASK_SUPERVISOR);
> > 
> > I'll fix it.
> 
> Can we break it out to make it more clear?
> 
> /*
>  * The state that came in from userspace was user-state only.
>  * Mask all the user states out of 'xfeatures'.
>  */
> xsave->header.xfeatures &= XFEATURE_MASK_SUPERVISOR;
> /*
>  * add back in the features that came in from userspace
>  */
> xsave->header.xfeatures |= xfeatures

I will update it in the next version. Thanks!