Re: [PATCH v3 05/11] KVM: page track: introduce kvm_page_track_{add,remove}_page

From: Xiao Guangrong
Date: Mon Feb 22 2016 - 23:27:11 EST




On 02/19/2016 07:37 PM, Paolo Bonzini wrote:


On 14/02/2016 12:31, Xiao Guangrong wrote:
+static bool check_mode(enum kvm_page_track_mode mode)
+{
+ if (mode < 0 || mode >= KVM_PAGE_TRACK_MAX)
+ return false;
+
+ return true;
+}

Oops, forgot about this; please rename to page_track_mode_is_valid and
make it "static inline".

Sure, it looks good to me. :)