Re: [PATCH v3] net: jme: fix suspend/resume on JMC260

[Diego Viola]

On Tue, Feb 23, 2016 at 12:04 PM, Diego Viola <diego.viola@xxxxxxxxx> wrote:
> The JMC260 network card fails to suspend/resume because the call to
> jme_start_irq() was too early, moving the call to jme_start_irq() after
> the call to jme_reset_link() makes it work.
>
> Prior this change suspend/resume would fail unless /sys/power/pm_async=0
> was explicitly specified.
>
> Relevant bug report: https://bugzilla.kernel.org/show_bug.cgi?id=112351
>
> Signed-off-by: Diego Viola <diego.viola@xxxxxxxxx>
> ---
>  drivers/net/ethernet/jme.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/jme.c b/drivers/net/ethernet/jme.c
> index b1de7af..8adbe8f 100644
> --- a/drivers/net/ethernet/jme.c
> +++ b/drivers/net/ethernet/jme.c
> @@ -3312,13 +3312,14 @@ jme_resume(struct device *dev)
>                 jme_reset_phy_processor(jme);
>         jme_phy_calibration(jme);
>         jme_phy_setEA(jme);
> -       jme_start_irq(jme);
>         netif_device_attach(netdev);
>
>         atomic_inc(&jme->link_changing);
>
>         jme_reset_link(jme);
>
> +       jme_start_irq(jme);
> +
>         return 0;
>  }
>
> --
> 2.7.1
>

I've sent this v3 patch and I think it's better than v2 and v1, as it
includes the link to my bug report and the description is better.

Diego