Re: [PATCH RESEND 1/2] usb: dwc2: Move register save and restore functions

From: Doug Anderson
Date: Tue Feb 23 2016 - 19:22:37 EST


John,

On Tue, Feb 23, 2016 at 1:33 PM, John Youn <johnyoun@xxxxxxxxxxxx> wrote:
> Move the register save and restore functions into the host and gadget
> specific files.
>
> Signed-off-by: John Youn <johnyoun@xxxxxxxxxxxx>
> ---
> drivers/usb/dwc2/core.c | 183 ----------------------------------------------
> drivers/usb/dwc2/core.h | 13 ++++
> drivers/usb/dwc2/gadget.c | 102 ++++++++++++++++++++++++++
> drivers/usb/dwc2/hcd.c | 64 ++++++++++++++++
> 4 files changed, 179 insertions(+), 183 deletions(-)

I picked these back to my chromeos-3.14 kernel (with many many dwc2
backports) and I confirmed that I can still compile the kernel, boot
it, and use USB. I also confirmed no warnings were introduced for me.
I'm only testing HOST, not gadget mode.

I also reviewed the code and agree that it looks good. Thanks!

Tested-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>