Re: [PATCH v5 14/15] scsi: ufs: add device quirk delay before putting UFS rails in LPM

From: Hannes Reinecke
Date: Tue Mar 01 2016 - 02:57:43 EST


On 02/28/2016 09:32 PM, Yaniv Gardi wrote:
> We put the UFS device in sleep state & UFS link in hibern8 state during
> runtime suspaned. After this we put all the UFS rails in low power
> modes immediately but it seems some devices may still draw more than
> sleep current from UFS rails (especially from VCCQ rail) atleast for
> 500us.
> To avoid this situation, this change adds 2ms delay before putting
> these UFS rails in LPM mode.
>
> Reviewed-by: Gilad Broner <gbroner@xxxxxxxxxxxxxx>
> Signed-off-by: Subhash Jadavani <subhashj@xxxxxxxxxxxxxx>
> Signed-off-by: Yaniv Gardi <ygardi@xxxxxxxxxxxxxx>
>
> ---
> drivers/scsi/ufs/ufs_quirks.c | 4 ++++
> drivers/scsi/ufs/ufs_quirks.h | 11 ++++++++++-
> drivers/scsi/ufs/ufshcd.c | 10 ++++++++++
> 3 files changed, 24 insertions(+), 1 deletion(-)
>
Reviewed-by: Hannes Reinecke <hare@xxxxxxx>

Cheers,

Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@xxxxxxx +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)