Re: [PATCH] tools build: use .s extension for preprocessed assembler code

[Arnaldo Carvalho de Melo]

Em Tue, Mar 01, 2016 at 02:31:10PM +0900, Masahiro Yamada escreveu:
> Hi Arnaldo,
> 
> Do you have any comment on this patch?

Sorry for the delay, I saw this patch, found no problems with it but was
waiting for Jiri's Ack, which he provided today, applying, thanks.

- Arnaldo
 
> (I hope I am addressing myself to a right person.
> "git log --pretty=fuller tools/build/Makefile.build" showed that
> several patches in this area had been applied by you.)
> 
> 
> Thanks,
> 
> 
> 2016-02-01 2:59 GMT+09:00 Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>:
> > The "man gcc" says .i extension represents the file is C source code
> > that should not be preprocessed.  Here, .s should be used.
> >
> > For clarification,
> >   .c  ---(preprocess)--->  .i
> >   .S  ---(preprocess)--->  .s
> >
> > Signed-off-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
> > ---
> >
> >  tools/build/Makefile.build | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/build/Makefile.build b/tools/build/Makefile.build
> > index 4a96473..ee566e8 100644
> > --- a/tools/build/Makefile.build
> > +++ b/tools/build/Makefile.build
> > @@ -85,7 +85,7 @@ $(OUTPUT)%.i: %.c FORCE
> >         $(call rule_mkdir)
> >         $(call if_changed_dep,cc_i_c)
> >
> > -$(OUTPUT)%.i: %.S FORCE
> > +$(OUTPUT)%.s: %.S FORCE
> >         $(call rule_mkdir)
> >         $(call if_changed_dep,cc_i_c)
> >
> > --
> > 1.9.1
> >
> 
> 
> 
> -- 
> Best Regards
> Masahiro Yamada