Re: [PATCH v2 1/3] ACPI/NFIT: Update Control Region Structure to comply ACPI 6.1

From: Toshi Kani
Date: Tue Mar 01 2016 - 10:58:34 EST


On Tue, 2016-03-01 at 15:13 +0000, Moore, Robert wrote:
>
> > -----Original Message-----
> > From: Toshi Kani [mailto:toshi.kani@xxxxxxx]
> > Sent: Monday, February 22, 2016 1:55 PM
> > To: rjw@xxxxxxxxxxxxx; Williams, Dan J
> > Cc: Moore, Robert; Zheng, Lv; elliott@xxxxxxx; linux-nvdimm@xxxxxxxxxxx
> > g;
> > linux-acpi@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> > devel@xxxxxxxxxx; Toshi Kani
> > Subject: [PATCH v2 1/3] ACPI/NFIT: Update Control Region Structure to
> > comply ACPI 6.1
> >
> > ACPI 6.1, Table 5-133, updates NVDIMM Control Region Structure as
> > follows.
> > Â- Valid Fields, Manufacturing Location, and Manufacturing Date
> > ÂÂÂare added from reserved range.ÂÂNo change in the structure size.
> > Â- IDs defined as SPD values are arrays of bytes.ÂÂThe spec
> > ÂÂÂclarified that they need to be represented as arrays of bytes
> > ÂÂÂas well.
> >
> > This patch makes the following changes to support this update.
> > Â- Change 'struct acpi_nfit_control_region' to reflect the update.
> > ÂÂÂSPD IDs are defined as arrays of bytes, so that they can be
> > ÂÂÂtreated in the same way regardless of CPU endianness and are
> > ÂÂÂnot miss-treated as little-endian numeric values.
>
>
> I don't think we are going to start changing the ACPI tables defined in
> the ACPICA headers because of this. We do in fact have macros for this
> purpose.

Can you elaborate what macros you suggest to use for this purpose?

Thanks,
-Toshi