Re: [RFC v2 3/7] firmware: port built-in section to linker table
From: James Bottomley
Date: Tue Mar 01 2016 - 11:10:33 EST
On Mon, 2016-02-29 at 10:12 +0000, David Woodhouse wrote:
> On Fri, 2016-02-19 at 05:45 -0800, Luis R. Rodriguez wrote:
> > This ports built-in firmware to use linker tables,
> > this replaces the custom section solution with a
> > generic solution.
> >
> > This also demos the use of the .rodata (SECTION_RO)
> > linker tables.
> >
> > Tested with 0 built-in firmware, 1 and 2 built-in
> > firmwares successfully.
>
> I think we'd do better to rip this support out entirely. It just
> isn't needed; firmware can live in an initramfs and don't even need
> *any* actual running userspace support to load it from there these
> days, do we?
We have lots of SCSI drivers with built in firmware. The obvious
examples are 53c700, aic7xxx and aic79xx. For them, we actually have
the firmware compilers in tree. The firmware model they use just isn't
amenable to the firmware loader: they're not monolithic blobs, it's a
set of firmware scripts we use to handle particular operations before
giving control back to the host, so the firmware and the driver are
very much symbiotic.
On the other hand, I don't think any of them uses firmware sections, so
it's not an argument for not ripping out this type.
James
Attachment:
smime.p7s
Description: S/MIME cryptographic signature